Skip to content

GH-35633: [R] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''#35634

Closed
thisisnic wants to merge 3 commits into
apache:mainfrom
thisisnic:GH-35633_tzs
Closed

GH-35633: [R] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''#35634
thisisnic wants to merge 3 commits into
apache:mainfrom
thisisnic:GH-35633_tzs

Conversation

@thisisnic

@thisisnic thisisnic commented May 17, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@thisisnic thisisnic requested a review from westonpace as a code owner May 17, 2023 09:48
@github-actions

github-actions Bot commented May 17, 2023

Copy link
Copy Markdown

@github-actions

github-actions Bot commented May 17, 2023

Copy link
Copy Markdown

⚠️ GitHub issue #35633 has been automatically assigned in GitHub to PR creator.

@thisisnic

thisisnic commented May 17, 2023

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-r-versions

@github-actions

github-actions Bot commented May 17, 2023

Copy link
Copy Markdown

Revision: e229100

Submitted crossbow builds: ursacomputing/crossbow @ actions-3beeb05939

Task Status
test-r-versions Github Actions

@thisisnic thisisnic requested a review from paleolimbot as a code owner May 17, 2023 14:37
jorisvandenbossche
jorisvandenbossche reviewed May 17, 2023
View reviewed changes
Comment thread cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc Outdated
@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels May 17, 2023
@thisisnic thisisnic changed the title GH-35633: [C++] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC'' GH-35633: [R] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC'' May 17, 2023
@github-actions github-actions Bot added awaiting change review Awaiting change review and removed Component: C++ awaiting changes Awaiting changes labels May 17, 2023
paleolimbot
paleolimbot reviewed May 18, 2023
View reviewed changes

@paleolimbot paleolimbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with skipping %z in the tests; however, you could also test the strptime format for %z. This seems to pass tests for me locally ( main...paleolimbot:arrow:r-assume-tz-fix2 ).

@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels May 18, 2023
@thisisnic

thisisnic commented May 18, 2023

Copy link
Copy Markdown
Member Author

I'm fine with skipping %z in the tests; however, you could also test the strptime format for %z. This seems to pass tests for me locally ( main...paleolimbot:arrow:r-assume-tz-fix2 ).

If you've already done that on another branch, can you make a PR with that and I'll just close this one then?

@paleolimbot

paleolimbot commented May 18, 2023

Copy link
Copy Markdown
Member

Sure!

@thisisnic thisisnic closed this May 18, 2023
@paleolimbot paleolimbot mentioned this pull request May 18, 2023
Merged
thisisnic pushed a commit that referenced this pull request May 18, 2023
@paleolimbot
GH-35633: [R] R builds failing with error 'Invalid: Timestamps alread…
9039ee2 
…y have a timezone: 'UTC'. Cannot localize to 'UTC'' (#35671)

Alternative approach to #35634.
* Closes: #35633

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments
@paleolimbot paleolimbot paleolimbot left review comments
@westonpace westonpace Awaiting requested review from westonpace

Assignees

No one assigned

Labels

awaiting changes Awaiting changes Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[R] R builds failing with error 'Invalid: Timestamps already have a timezone: 'UTC'. Cannot localize to 'UTC''

3 participants

@thisisnic @paleolimbot @jorisvandenbossche